rate-limit PPMS lookup to curb abuse (REDUX) #7673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lindsey Hattamer <lindsey.hattamer@oddball.io> Co-authored-by: Travis Hilton <travis.hilton@oddball.io>
f1337
force-pushed
the
f1337/2021-08-17-DOS-activity
branch
from
c74b14e to
759ac3b
Compare
Co-authored-by: Lindsey Hattamer <lindsey.hattamer@oddball.io> Co-authored-by: Riley Anderson <riley.anderson@oddball.io>
rileyanderson
previously approved these changes
Aug 18, 2021
rileyanderson
approved these changes
Aug 18, 2021
spec/middleware/rack/attack_spec.rb
Outdated
| @@ -101,11 +101,11 @@ def app | |||
|
|
|||
| before do | |||
| limit.times do | |||
| get endpoint, params: nil, session: headers | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to ongoing DOS activity against the Facility Locator remote Bing Maps lookup.
Please see https://github.com/department-of-veterans-affairs/va.gov-team-sensitive/blob/master/Postmortems/2021-08-16-facility-locator-possible-DOS.md for add'l details.
Now with
remote_ip, because we're behind an ELB.